TclTLS: View Ticket

2024-05-28
00:36		• Closed ticket [539d25f105]: The isServer argument of CTX_Init() is unused plus 5 other changes artifact: 63a8a21de0 user: bohagan
2023-11-20
02:46		• New ticket [539d25f105]. artifact: ea32995d09 user: doofus

Ticket Hash:	539d25f105a84615256eff74bdf78baff7fd51e5
Title:	The isServer argument of CTX_Init() is unused
Status:	Closed	Type:	Code Defect
Severity:	Critical	Priority:	Immediate
Subsystem:		Resolution:	Open
Last Modified:	2024-05-28 00:36:03 1.43 years ago	Created:	2023-11-20 02:46:47 1.95 years ago
Version Found In:	1.7.22

User Comments:

doofus added on 2023-11-20 02:46:47:

Compiler warns of the isServer function parameter being unused. Seems like it can, indeed, be safely removed:

--- tls.c       2020-10-12 16:39:22.000000000 -0400
+++ tls.c       2023-11-19 21:30:03.357601000 -0500
@@ -62,5 +62,5 @@
                        Tcl_Interp *interp, int objc, Tcl_Obj *CONST objv[]);

-static SSL_CTX *CTX_Init(State *statePtr, int isServer, int proto, char *key,
+static SSL_CTX *CTX_Init(State *statePtr, int proto, char *key,
                        char *certfile, unsigned char *key_asn1, unsigned char *cert_asn1,
                        int key_asn1_len, int cert_asn1_len, char *CAdir, char *CAfile,
@@ -897,5 +897,5 @@
        ctx = ((State *)Tcl_GetChannelInstanceData(chan))->ctx;
     } else {
-       if ((ctx = CTX_Init(statePtr, server, proto, keyfile, certfile, key,
+       if ((ctx = CTX_Init(statePtr, proto, keyfile, certfile, key,
     cert, key_len, cert_len, CAdir, CAfile, ciphers,
     DHparams)) == (SSL_CTX*)0) {
@@ -1067,8 +1067,7 @@

 static SSL_CTX *
-CTX_Init(statePtr, isServer, proto, keyfile, certfile, key, cert,
+CTX_Init(statePtr, proto, keyfile, certfile, key, cert,
          key_len, cert_len, CAdir, CAfile, ciphers, DHparams)
     State *statePtr;
-    int isServer;
     int proto;
     char *keyfile;

bohagan added on 2024-05-28 00:36:03:

This is OBE by the changes in [f9da715266587d3f].